Conversation
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses two CI failures. The first is a FileNotFoundError which is resolved by correcting a dataset path. The second failure, an AssertionError following a vllm upgrade, is fixed by parameterizing a test to include a MoE model, which likely covers the failing code path. The changes are well-targeted and correct. I have one minor suggestion to improve code clarity by removing a redundant parameter.
| max_input_length=max_input_length, | ||
| max_generate_length=1000, | ||
| data_path=os.path.expanduser("/mnt/cluster_storage/data/gsm8k/validation.parquet"), | ||
| data_path=os.path.expanduser("~/data/gsm8k/validation.parquet"), |
Contributor
devpatelio
pushed a commit
that referenced
this pull request
Mar 20, 2026
…e; Use the correct GSM8k path for `test_generator_multi_turn_gsm8k_router_replay` (#1339)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes CI failures on main right now: https://github.com/NovaSky-AI/SkyRL/actions/runs/23218100038/job/67484003027
tests/backends/skyrl_train/gpu/gpu_ci/test_skyrl_gym_generator.py::test_generator_multi_turn_gsm8k_router_replay - FileNotFoundError: Unable to find '/mnt/cluster_storage/data/gsm8k/validation.parquet'-> R3 PR: Rollout Routing Replay #1273 added a router replay test but used an incorrect path for the GSM8K dataset on CItests/backends/skyrl_train/gpu/gpu_ci/inference_servers/test_weight_sync.py::TestColocatedIpcWeightUpdateFlow::test_update_weights_ipc-> Similar fix as in [CI] Skip FlashRL integration test in CI and fix failing generation test for new inference codepath #1301