[cleanup] Remove NCCL_CUMEM_ENABLE=0 from prepare_runtime_environment #1600
Merged
Merged
Conversation
SumanthRH
approved these changes
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the logic that sets the NCCL_CUMEM_ENABLE environment variable to '0' when the NCCL weight synchronization backend is used during runtime environment preparation. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously had the following snippet in
prepare_runtime_environmentThe NCCL bug that required this was resolved in NCCL 2.22.3, and this override was removed from vLLM:
NCCL: NVIDIA/nccl#1234
vLLM: vllm-project/vllm#24141
Since the resolved NCCL version is shipped with PyTorch, and we are pinned to 2.10.0 (NCCL 2.26.2), it seems safe to remove this env var for older NCCL versions.
In fact, Nemo-RL actually sets this env-var to 1 (link).
Verified that GSM8K still works with this flag removed both colocated and non-colocated, and with vllm tp=2
We see that max gpu memory utilization is also slightly lower with this env var removed, as it enables newer NCCL version memory optimizations (as mentioned in vllm-project/vllm#24141):