[fix] Fix num_padding_microbatches metric for Megatron backend#1856
Merged
Conversation
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the calculation of real and padding microbatches in megatron_worker.py. Instead of inferring the number of real microbatches by checking if the loss_mask sum is greater than zero, it now retrieves the padding count directly from the microbatch_iterator via num_padding_microbatches. This prevents real microbatches with an all-zero loss mask (e.g., due to DAPO overlong filtering) from being incorrectly classified as padding. Additionally, the status reporting is updated to use this padding count directly. There are no review comments, so no feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
num_padding_microbatchesmetric calculation for the Megatron backend when there are real sequences with all zero loss masks (example withapply_overlong_filtering=true)The number of padding microbatches should not count all sequences with zero loss mask because some of these are real sequences but masked out for loss calculation.
The fix is to read the
num_padding_microbatchesattribute from themicrobatch_iteratorwhen available.