[Configs] Add placement related validation in validate_cfg#411
Merged
SumanthRH merged 5 commits intoNovaSky-AI:mainfrom Oct 9, 2025
Merged
[Configs] Add placement related validation in validate_cfg#411SumanthRH merged 5 commits intoNovaSky-AI:mainfrom
validate_cfg#411SumanthRH merged 5 commits intoNovaSky-AI:mainfrom
Conversation
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves placement-related validation into validate_cfg to fail faster and improve the user experience, which is a good change. The logic appears correct. I've added a couple of suggestions to improve the clarity of assertion error messages, which will help with debugging configuration issues.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…olocate Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Lucas-Fernandes-Martins
pushed a commit
to Lucas-Fernandes-Martins/SkyRL
that referenced
this pull request
Oct 11, 2025
…-AI#411) # What does this PR do? Adds placement related validation in `validate_cfg`. Currently, this is checked in `RayPPOTrainer.build_models` which is pretty late. For example, with colocation enabled, inference engines are initialized and only later the check is triggered. With this PR, basic validation happens right at the beginning and is better user exp --------- Signed-off-by: SumanthRH <sumanthrh99@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
…-AI#411) # What does this PR do? Adds placement related validation in `validate_cfg`. Currently, this is checked in `RayPPOTrainer.build_models` which is pretty late. For example, with colocation enabled, inference engines are initialized and only later the check is triggered. With this PR, basic validation happens right at the beginning and is better user exp --------- Signed-off-by: SumanthRH <sumanthrh99@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds placement related validation in
validate_cfg. Currently, this is checked inRayPPOTrainer.build_modelswhich is pretty late. For example, with colocation enabled, inference engines are initialized and only later the check is triggered. With this PR, basic validation happens right at the beginning and is better user exp