Skip to content

[Fix] Fix GPT-OSS example#431

Merged
SumanthRH merged 1 commit intoNovaSky-AI:mainfrom
SumanthRH:fix-gptoss-example
Oct 8, 2025
Merged

[Fix] Fix GPT-OSS example#431
SumanthRH merged 1 commit intoNovaSky-AI:mainfrom
SumanthRH:fix-gptoss-example

Conversation

@SumanthRH
Copy link
Copy Markdown
Member

@SumanthRH SumanthRH commented Oct 8, 2025

The config parameter reasoning_effort needs a + otherwise you'll see:

Could not override 'generator.chat_template_kwargs'.
To append to your config use +generator.chat_template_kwargs={reasoning_effort:low}
Key 'reasoning_effort' is not in struct
    full_key: generator.chat_template_kwargs.reasoning_effort
    object_type=dict

This was added by mistake in #390 while I was testing the script

x
Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

I've reviewed the changes and have one suggestion to improve the robustness of the shell script. Overall, the fix seems correct.

@SumanthRH SumanthRH merged commit 4ddb1e7 into NovaSky-AI:main Oct 8, 2025
3 checks passed
li-boxuan pushed a commit to li-boxuan/SkyRL that referenced this pull request Nov 23, 2025
The config parameter `reasoning_effort` needs a + otherwise you'll see: 

```bash
Could not override 'generator.chat_template_kwargs'.
To append to your config use +generator.chat_template_kwargs={reasoning_effort:low}
Key 'reasoning_effort' is not in struct
    full_key: generator.chat_template_kwargs.reasoning_effort
    object_type=dict
```

This was added by mistake in NovaSky-AI#390 while I was testing the script

Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant