Skip to content

Conversation

@devpatelio
Copy link
Collaborator

No description provided.

@devpatelio devpatelio merged commit bd22558 into main Oct 29, 2025
@devpatelio devpatelio deleted the comment branch October 29, 2025 23:04
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for using Modal for SkyRL training and includes a clarifying comment in the Megatron worker. The new documentation is a great addition, providing a good overview for users. My review focuses on improving the accuracy and clarity of the documentation by pointing out a discrepancy with the implementation, suggesting a more robust command example, and fixing a minor grammatical error. I've also suggested a small formatting improvement to the new comment in the worker code for better readability.

li-boxuan pushed a commit to li-boxuan/SkyRL that referenced this pull request Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants