Cleanup stray doc #599
Merged
Cleanup stray doc #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the documentation file skyrl-train/docs/tutorials/modal.rst. As the pull request description suggests, this is a stray file. My review confirms that this file is not referenced in the main documentation index (docs/index.rst) or other provided files, so its removal will not cause broken links. Furthermore, the content of the deleted file appears to be outdated and less accurate than the existing skyrl-train/integrations/modal/README.md. This change is a good cleanup, and I approve it.
li-boxuan
pushed a commit
to li-boxuan/SkyRL
that referenced
this pull request
Nov 23, 2025
# What does this PR do? Cleans up a stray doc file introduced in NovaSky-AI#597 . We will have a great integration page with Modal very soon Signed-off-by: SumanthRH <sumanthrh99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleans up a stray doc file introduced in #597 .
We will have a great integration page with Modal very soon