Skip to content

Conversation

@erictang000
Copy link
Collaborator

What does this PR do

Cleans up _parse_action to just parse the action:

def _parse_action(self, action: str) -> List[Optional[str]]:
        match = None
        if "<search>" in action and "</search>" in action:
            match = re.search(r"<search>(.*?)</search>", action, re.DOTALL)
        return [match.group(1)] if match else [None]

since we are always using

tool_group_name = self.tool_group.get_name()
tool_name = self.tool_group.get_tool_names()[0]

@erictang000 erictang000 requested a review from tyler-griggs July 10, 2025 06:58
Copy link
Member

@tyler-griggs tyler-griggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you haven't already, could you just launch a training run for 1 step to sanity check that this all works?

@erictang000
Copy link
Collaborator Author

Thanks! If you haven't already, could you just launch a training run for 1 step to sanity check that this all works?

image training is running!

@erictang000 erictang000 merged commit 42fe96c into main Jul 10, 2025
3 checks passed
@erictang000 erictang000 deleted the erictang000/search_env_cleanup branch July 10, 2025 19:26
fannie1208 pushed a commit to vinid/SkyRL that referenced this pull request Aug 19, 2025
# What does this PR do
Cleans up `_parse_action` to just parse the action:
```python
def _parse_action(self, action: str) -> List[Optional[str]]:
        match = None
        if "<search>" in action and "</search>" in action:
            match = re.search(r"<search>(.*?)</search>", action, re.DOTALL)
        return [match.group(1)] if match else [None]
```

since we are always using 

```python
tool_group_name = self.tool_group.get_name()
tool_name = self.tool_group.get_tool_names()[0]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants