[tx] Add EP axis to deepseek#993
Merged
pcmoritz merged 4 commits intoNovaSky-AI:mainfrom Jan 30, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for expert parallelism (EP axis) for the Deepseek V3 model, a crucial feature for efficiently training Mixture-of-Experts models. A security review, however, identified a potential Denial of Service vulnerability due to missing validation of the adapter_indices parameter, which could lead to crashes if out-of-bounds indices are provided. Additionally, a minor suggestion is to improve code formatting for better readability.
Collaborator
|
Very nice ❤️ ! With this PR, the step time for SFT on GLM 4.7 Flash goes down from 60s to 35s :) |
pcmoritz
approved these changes
Jan 30, 2026
Contributor
Author
|
Thanks for the review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds EP axis to deepseek, simplifies some variables to match Qwen's
Testing...