This repository was archived by the owner on Jul 5, 2023. It is now read-only.
MP-6876: CountryCode3 definition and implementation #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
originalethanhunt
force-pushed
the
feature/MP-6876_CountryCode3_definition_and_implementation
branch
from
706523e to
3865b65
Compare
rochar
suggested changes
Jun 26, 2023
Collaborator
rochar
left a comment
rochar
left a comment
There was a problem hiding this comment.
looks good, a few small comments
The build is failing
take a look at https://regusit.atlassian.net/wiki/spaces/NOX/pages/3154116635/Self+Code+Review
originalethanhunt
force-pushed
the
feature/MP-6876_CountryCode3_definition_and_implementation
branch
2 times, most recently
from
a619773 to
cca9ae1
Compare
originalethanhunt
force-pushed
the
feature/MP-6876_CountryCode3_definition_and_implementation
branch
from
cca9ae1 to
2cacbfd
Compare
rochar
approved these changes
Jun 27, 2023
jan-schutte
approved these changes
Jun 27, 2023
jan-schutte
deleted the
feature/MP-6876_CountryCode3_definition_and_implementation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.