This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Internet domain value object implementation #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochar
suggested changes
Jun 26, 2023
Collaborator
rochar
left a comment
rochar
left a comment
There was a problem hiding this comment.
looks, good, add a few small comments
tests/Nox.Types.Tests/Types/InternetDomain/InternetDomainTests.cs
Outdated
Show resolved
Hide resolved
tests/Nox.Types.Tests/Types/InternetDomain/InternetDomainTests.cs
Outdated
Show resolved
Hide resolved
msadikkoseaupa
force-pushed
the
feature/internet_domain_value_object
branch
from
f09ce6d to
a1b52bc
Compare
rochar
previously approved these changes
Jun 26, 2023
…in_value_object # Conflicts: # tests/Nox.Types.Tests/EntityFrameworkTests/Configuration/CountryDbConfiguration.cs # tests/Nox.Types.Tests/EntityFrameworkTests/Models/Country.cs # tests/Nox.Types.Tests/EntityFrameworkTests/NoxTypesEntityFrameworkTests.cs
jan-schutte
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.