Skip to content

Add LLDP local port ID discovery and mapping via ports_lldplocportid …#1

Open
jayib wants to merge 2 commits intoNpeca75:lldpfrom
jayib:lldp
Open

Add LLDP local port ID discovery and mapping via ports_lldplocportid …#1
jayib wants to merge 2 commits intoNpeca75:lldpfrom
jayib:lldp

Conversation

@jayib
Copy link
Copy Markdown

@jayib jayib commented Oct 29, 2025

…table

Please give a short description what your pull request is for

I've added functions to save the lldpLocPortId to the new ports_lldplocportid table in the database. It saves the lldpLocPortId in a row with the LibreNMS port ID and device ID, so that these can be used for link discovery. This way even devices which advertise their MAC address for lldpLocPortId can have port links by finding the corresponding device ID and port ID.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@jayib
Copy link
Copy Markdown
Author

jayib commented Jan 22, 2026

Hi @Npeca75.I know you’ve been working on related LLDP discovery changes and I don’t want to step on that work.

We’ve been seeing consistent discovery failures with devices that return MAC-style LLDP identifiers (e.g. Avaya ERS), and this MR was an attempt to make that data reusable across discovery runs.

If this conflicts with your approach or isn’t something you want merged, no worries. Just wanted to check whether I should keep this updated, rework it, or drop it entirely.

Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant