Add LLDP local port ID discovery and mapping via ports_lldplocportid …#1
Open
jayib wants to merge 2 commits intoNpeca75:lldpfrom
Open
Add LLDP local port ID discovery and mapping via ports_lldplocportid …#1jayib wants to merge 2 commits intoNpeca75:lldpfrom
jayib wants to merge 2 commits intoNpeca75:lldpfrom
Conversation
3 tasks
eb973ed to
fbc36bd
Compare
Author
|
Hi @Npeca75.I know you’ve been working on related LLDP discovery changes and I don’t want to step on that work. We’ve been seeing consistent discovery failures with devices that return MAC-style LLDP identifiers (e.g. Avaya ERS), and this MR was an attempt to make that data reusable across discovery runs. If this conflicts with your approach or isn’t something you want merged, no worries. Just wanted to check whether I should keep this updated, rework it, or drop it entirely. Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…table
Please give a short description what your pull request is for
I've added functions to save the lldpLocPortId to the new ports_lldplocportid table in the database. It saves the lldpLocPortId in a row with the LibreNMS port ID and device ID, so that these can be used for link discovery. This way even devices which advertise their MAC address for lldpLocPortId can have port links by finding the corresponding device ID and port ID.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.