Add bundler parameter to ExecutionContext
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in ruby/rubygems@076aba8 is causing the bundler to attempt to reload the script, if the used Bundler version doesn't match that, specified in the Gemfile.lock. This causes issues (#3). A quick workaround for that is to run the remote script using `bundle exec`. In order to do this, I introduced a `bundler` parameter to the execution context (false by default). We will have to address this properly in the future versions.
Pull Request Test Coverage Report for Build 12352744400Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issue #3 this introduces a new
bundlerparameter which allows STDIN-type adapters to execute remote scripts usingbundle exec.