This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Add Status column to TrustedTimestamp entity#135
Merged
loic-sharma merged 2 commits intomasterfrom Feb 5, 2018
Merged
Conversation
joelverhagen
approved these changes
Feb 5, 2018
loic-sharma
added a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Feb 6, 2018
Updates `NuGet.Services.*` dependencies to add the `Status` property to `TrustedTimestamp` entities. Also modified the Extract & Validate job to properly initialize timestamp's status as `Valid`. Depends on NuGet/ServerCommon#135
joelverhagen
pushed a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Oct 26, 2020
Updates `NuGet.Services.*` dependencies to add the `Status` property to `TrustedTimestamp` entities. Also modified the Extract & Validate job to properly initialize timestamp's status as `Valid`. Depends on NuGet/ServerCommon#135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During signature validation,
TrustedTimestampthat are no longer trusted are treated as if they don't exist. Today, we have to manually inspect a timestamp and its certificates to determine whether the timestamp is valid and trusted. This newStatuscolumn will be updated to reflect timestamps' latest known status, thereby making it easier to filter outTrustedTimestamps that are no longer trusted during package signature validation.StatusisInvalid. After we run the migrations, ALLTrustedTimestamps will be marked asInvalid. We will need to fix the E&V job to properly markTrustedTimestamps asValid, then,TrustedTimestamps in the database will need to be fixed up with the following SQL query: