Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Ensure build script works on VS2019-only machine#307

Merged
xavierdecoster merged 1 commit intomasterfrom
dev-issue2661
Aug 28, 2019
Merged

Ensure build script works on VS2019-only machine#307
xavierdecoster merged 1 commit intomasterfrom
dev-issue2661

Conversation

@xavierdecoster
Copy link
Copy Markdown
Contributor

Copied the relevant functions from NuGet/NuGet.Client repo.

@joelverhagen
Copy link
Copy Markdown
Member

This works okay on the CI (nuget.visualstudio.com) and release (devdiv.visualstudio.com) agents?

@xavierdecoster
Copy link
Copy Markdown
Contributor Author

This works okay on the CI (nuget.visualstudio.com) and release (devdiv.visualstudio.com) agents?

CI for this PR is green (nuget.visualstudio.com). How can I test release agents without releasing this private branch?

@xavierdecoster
Copy link
Copy Markdown
Contributor Author

Verified a private branch for NuGetDeployment on the default Agent Pool.

Given the other pipelines run on the same Agent Pool, I don't expect any issues with this change.

I also modified the following build.ps1 files and tested the change locally using commit SHA: b025102b17519474d1921d0c44aac62d15024df9 (which points to the build files in this very PR).

Please let me know if I need to perform a specific additional test before merging this PR.

@joelverhagen @ryuyu.

@xavierdecoster
Copy link
Copy Markdown
Contributor Author

Ping

@xavierdecoster xavierdecoster merged commit 1f60ff3 into master Aug 28, 2019
@xavierdecoster xavierdecoster deleted the dev-issue2661 branch August 28, 2019 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants