This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Align Microsoft.Extensions.Logging dependency for ServerCommon solution#317
Merged
xavierdecoster merged 1 commit intomasterfrom Oct 14, 2019
Merged
Align Microsoft.Extensions.Logging dependency for ServerCommon solution#317xavierdecoster merged 1 commit intomasterfrom
xavierdecoster merged 1 commit intomasterfrom
Conversation
xavierdecoster
requested review from
agr,
joelverhagen,
loic-sharma,
ryuyu,
scottbommarito and
skofman1
joelverhagen
approved these changes
Oct 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many consumers of ServerCommon dependencies already manually added and upgraded the
Microsoft.Extensions.Loggingdependency to version 1.1.2.All other ServerCommon libraries already use version 1.1.2. Only
NuGet.Services.Loggingwas lagging behind to version 1.0.0.This PR updates and aligns this dependency for
NuGet.Services.Logging, and allows us to remove the explicit top-level dependency toMicrosoft.Extensions.Loggingelsewhere, making it a transitive one instead, which makes it easier to maintain our dependencies across the board.