This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Make ApplicationInsightsConfiguration implement IDisposable#323
Merged
xavierdecoster merged 1 commit intomasterfrom Dec 4, 2019
Merged
Make ApplicationInsightsConfiguration implement IDisposable#323xavierdecoster merged 1 commit intomasterfrom
xavierdecoster merged 1 commit intomasterfrom
Conversation
xavierdecoster
requested review from
agr,
cristinamanum,
joelverhagen,
loic-sharma and
ryuyu
joelverhagen
reviewed
Dec 4, 2019
| /// </summary> | ||
| public DiagnosticsTelemetryModule DiagnosticsTelemetryModule { get; } | ||
|
|
||
| public void Dispose() |
Member
There was a problem hiding this comment.
Who's responsibility is it to call this dispose?
Contributor
Author
There was a problem hiding this comment.
The caller of ApplicationInsights.Initialize, which typically is the application host that will configure DI and handle lifetime of those objects.
joelverhagen
approved these changes
Dec 4, 2019
cristinamanum
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See NuGet/NuGet.Jobs#837 (comment)