This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Moved DeploymentIdTelemetryEnricher to NuGet.Services.Logging#328
Merged
xavierdecoster merged 2 commits intomasterfrom Jan 6, 2020
Merged
Moved DeploymentIdTelemetryEnricher to NuGet.Services.Logging#328xavierdecoster merged 2 commits intomasterfrom
xavierdecoster merged 2 commits intomasterfrom
Conversation
xavierdecoster
requested review from
agr,
joelverhagen,
loic-sharma,
ryuyu,
skofman1 and
zhhyu
joelverhagen
approved these changes
Dec 31, 2019
zhhyu
approved these changes
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed there's 90% similar code in
DeploymentIdTelemetryEnricherliving in NuGetGallery, andDeploymentLabelTelemetryEnricher. Created common base class, and initializingDeploymentIdis a caller responsibility now, which removes the dependency to Azure SDK for this enricher, so we can move it here next to the rest of our logging infrastructure.