This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Port MachineNameTelemetryInitializer from NuGet.ApplicationInsights.Owin#330
Merged
xavierdecoster merged 1 commit intomasterfrom Jan 9, 2020
Merged
Port MachineNameTelemetryInitializer from NuGet.ApplicationInsights.Owin#330xavierdecoster merged 1 commit intomasterfrom
xavierdecoster merged 1 commit intomasterfrom
Conversation
xavierdecoster
requested review from
agr,
cristinamanum,
dannyjdev,
joelverhagen,
loic-sharma,
ryuyu,
shishirx34,
skofman1 and
zhhyu
xavierdecoster
commented
Jan 9, 2020
| { | ||
| } | ||
|
|
||
| private static string TryGetMachineName() |
Contributor
Author
There was a problem hiding this comment.
Current version lives here: https://github.com/NuGet/NuGet.Services.Metadata/blob/master/src/NuGet.ApplicationInsights.Owin/MachineNameTelemetryInitializer.cs
Note that we now inherit from SupportPropertiesTelemetryInitializer which uses the proper AppInsights API to set properties. The current version in NuGet.ApplicationInsights.Owin still uses the obsolete API via TelemetryContext.
joelverhagen
approved these changes
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type belongs in
NuGet.Services.Loggingas it can be generally reused and is not specific toOwin.In addition, there's no need to retrieve the machine name from
Environment.MachineNameon every telemetry initialization, which may happen multiple times for the same telemetry item.