This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Update KeyVault to use Managed Identities#334
Merged
shishirx34 merged 10 commits intomasterfrom Feb 6, 2020
Merged
Conversation
shishirx34
requested review from
agr,
cristinamanum,
dannyjdev,
joelverhagen,
loic-sharma,
ryuyu and
skofman1
Member
|
UTs? |
Contributor
Author
|
I will be adding the tests here, just wanted to get the PR out for review asap. |
joelverhagen
reviewed
Feb 5, 2020
joelverhagen
reviewed
Feb 5, 2020
skofman1
reviewed
Feb 5, 2020
skofman1
reviewed
Feb 5, 2020
skofman1
reviewed
Feb 5, 2020
joelverhagen
approved these changes
Feb 6, 2020
Member
joelverhagen
left a comment
joelverhagen
left a comment
There was a problem hiding this comment.
UTs the best you can, then 
ryuyu
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to be consumed in the code and in to be used in Jobs.Common