This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Remove the validation step's types#356
Merged
loic-sharma merged 4 commits intomasterfrom Jan 29, 2021
Merged
Conversation
This was referenced Jan 28, 2021
loic-sharma
requested review from
agr,
dannyjdev,
drewgillies,
joelverhagen,
lyndaidaii,
ryuyu,
shishirx34,
skofman1 and
zhhyu
zhhyu
approved these changes
Jan 28, 2021
agr
approved these changes
Jan 28, 2021
loic-sharma
added a commit
to NuGet/NuGetGallery
that referenced
this pull request
Jan 29, 2021
Brings in the changes from: NuGet/ServerCommon#356. This will be used to create a new `NuGetGallery.Core` package to update the Orchestrator. See: NuGet/NuGet.Jobs#958 Part of: https://github.com/NuGet/Engineering/issues/3614
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the
IProcessor,IValidationRequest,IValidationResult,IValidator, andValidationResulttypes as they will be moved to the NuGet.Jobs repository (see NuGet/NuGet.Jobs#958).These types were originally in the ServerCommon repository to allow for Orchestrator validators in private repositories. This flexibility adds serious engineering overhead, and we don't plan on adding validators in private repositories.
Part of: https://github.com/NuGet/Engineering/issues/3614