This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Move from WindowsAzure.ServiceBus to Azure.Messaging.ServiceBus#412
Merged
joelverhagen merged 11 commits intomainfrom Sep 21, 2023
Merged
Move from WindowsAzure.ServiceBus to Azure.Messaging.ServiceBus#412joelverhagen merged 11 commits intomainfrom
joelverhagen merged 11 commits intomainfrom
Conversation
mariaghiondea
previously approved these changes
Sep 6, 2023
mariaghiondea
left a comment
There was a problem hiding this comment.
Thank you for the work on this one!
Anything that we can do to prevent regressions, especially anything that would come up at runtime?
Member
Author
I've updated the PR description with details. In short: full deployment of all SB-interacting component in DEV/INT prior to PROD (as expected) and a careful deployment in PROD where we move listeners slowly and services (i.e. senders = gallery) later. |
agr
reviewed
Sep 9, 2023
agr
reviewed
Sep 9, 2023
agr
previously approved these changes
Sep 9, 2023
Contributor
agr
left a comment
There was a problem hiding this comment.
Feel free to ignore my comments, nothing important there.
78754e0
This was referenced Sep 20, 2023
mariaghiondea
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address https://github.com/NuGet/Engineering/issues/5011
Summary of changes:
IReceivedBrokeredMessage. This mirrors a similar split in the send and receive message models in the new SDK.sb://namespace/style connection strings (old SDK supports it, new SDK does not)Testing strategy: