fix(plugin): use per-platform winCodeSign archives to fix AppX build on Windows#48
Merged
Merged
Conversation
kdroidFilter
changed the title
…on Windows The legacy combo winCodeSign-2.6.0.7z archive contains macOS symlinks that cannot be created on Windows without admin rights or Developer Mode, causing app-builder to fail with "exit status 2" during extraction (electron-builder#8149). Set toolsets.winCodeSign to "1.0.0" in the generated electron-builder config to download per-platform archives that do not contain cross-platform symlinks.
kdroidFilter
force-pushed
the
fix/appx-wincodesign-download-failure
branch
from
8749fda to
e9af3a5
Compare
kdroidFilter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46 — AppX builds fail on Windows with
exit status 2fromapp-builderwhen extractingwinCodeSign-2.6.0.7z.Root cause: The legacy combo
winCodeSign-2.6.0.7zarchive contains macOS symlinks (darwin/10.12/lib/libcrypto.dylib,libssl.dylib). On Windows, creating symlinks requires admin rights or Developer Mode enabled. Without either, the embedded 7-Zip extraction inapp-builderfails withexit status 2(electron-builder#8149).Fix: Set
toolsets.winCodeSign: "1.0.0"in the generatedelectron-builder.ymlconfig. This makes electron-builder download per-platform code-signing archives (introduced in electron-builder#9430) that do not contain cross-platform symlinks.Changes
ElectronBuilderConfigGenerator.kt: emittoolsets.winCodeSign: "1.0.0"on Windows buildsTest plan
winCodeSign-2.6.0.7zis no longer downloaded (replaced by per-platform archive)toolsetskey emitted)