Skip to content

fix: prepend api. prefix in NullifyClient and use POST for metrics overview#135

Merged
jonathanlam merged 1 commit intomainfrom
fix/api-host-prefix-and-status-method
Mar 18, 2026
Merged

fix: prepend api. prefix in NullifyClient and use POST for metrics overview#135
jonathanlam merged 1 commit intomainfrom
fix/api-host-prefix-and-status-method

Conversation

@jonathanlam
Copy link
Member

@jonathanlam jonathanlam commented Mar 18, 2026

Summary

  • NullifyClient and refreshingAuthTransport were building BaseURL without the api. prefix (e.g. https://x.nullify.ai instead of https://api.x.nullify.ai), causing TLS errors on all requests through the legacy client
  • authTransport was overriding the request URL host on every round-trip, reverting the correct host set by BaseURL
  • status command was using GET for /admin/metrics/overview, which is a POST endpoint requiring a {"query":{}} body

Test plan

  • nullify status returns full security posture overview
  • nullify repos lists repositories
  • nullify findings --type sast returns findings
  • All unit tests pass (make unit)

…erview

NullifyClient and refreshingAuthTransport were constructing BaseURL
without the api. prefix, and authTransport was overriding the request
host back to the bare form. The status command was also using GET
instead of POST for /admin/metrics/overview.
@jonathanlam jonathanlam added the patch Patch version updates (fixes) label Mar 18, 2026
@jonathanlam jonathanlam marked this pull request as ready for review March 18, 2026 03:11
@jonathanlam jonathanlam enabled auto-merge March 18, 2026 04:19
@jonathanlam jonathanlam added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 1325a87 Mar 18, 2026
2 of 3 checks passed
@jonathanlam jonathanlam deleted the fix/api-host-prefix-and-status-method branch March 18, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch version updates (fixes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants