Optimize condition for removing written data in BufWriter #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NobodyXu merged 7 commits into main from NobodyXu-patch-1

Nov 9, 2025

Collaborator

NobodyXu commented Nov 9, 2025

Do it strategically, when:

it can use a memcpy instead of memmove to remove it
when no space left for new data


          Optimize condition for removing written data in BufWriter

8c65d8d

Do it strategically, when:
 - it can use a memcpy instead of memmove to remove it
 - when no space left for new data

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu commented

View reviewed changes

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved


          Fix typo

2f4b413

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu commented

View reviewed changes

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved


          Replace multiplication with division

To prevent overflo

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu commented

View reviewed changes

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved


          Update crates/async-compression/src/generic/write/buf_writer.rs

cf15ee1

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu commented

View reviewed changes

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved


          Do copyback at 512B flushed data

7af5d6e

So that memmove AVX256 can be used to do the copyback,
which should be reasonably fast

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu commented

View reviewed changes

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved


          Fix commit issues

a222a32

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu commented

View reviewed changes

crates/async-compression/src/generic/write/buf_writer.rs Outdated Show resolved Hide resolved


          Fix fmt

7a13493

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>

NobodyXu added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

NobodyXu added this pull request to the merge queue

Merged via the queue into main with commit 63a83ad

20 checks passed

NobodyXu deleted the NobodyXu-patch-1 branch

November 9, 2025 14:59

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (47667f0) to head (7a13493).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #415   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions bot mentioned this pull request

chore: release #417

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet