Skip to content

Optimize condition for removing written data in BufWriter #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 9, 2025
Merged

Optimize condition for removing written data in BufWriter #415

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c65d8d
Optimize condition for removing written data in BufWriter
NobodyXu Nov 9, 2025
2f4b413
Fix typo
NobodyXu Nov 9, 2025
9183145
Replace multiplication with division
NobodyXu Nov 9, 2025
cf15ee1
Update crates/async-compression/src/generic/write/buf_writer.rs
NobodyXu Nov 9, 2025
7af5d6e
Do copyback at 512B flushed data
NobodyXu Nov 9, 2025
a222a32
Fix commit issues
NobodyXu Nov 9, 2025
7a13493
Fix fmt
NobodyXu Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/async-compression/src/generic/write/buf_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,13 @@ impl BufWriter {
) -> Poll<io::Result<&mut [u8]>> {
ready!(self.partial_flush_buf(poll_write))?;

if self.written > 0 {
// when the flushed data is larger than or equal to half of yet-to-be-flushed data,
// the copyback could use version of memcpy that do copies from the head of the buffer.
// Anything smaller than that, an overlap would happen that forces use of memmove.
if self.written >= (self.buffered / 3)
|| self.written >= 512
|| self.buffered == self.buf.len()
{
self.remove_written();
}

Expand Down