N-dimensional slicing and element-wise iterator #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: N-dimensional transpose and automatic C contiguous conversion to avoid non-contiguous lack of support.
henrique-borba
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix: stable N-dimensional slicing
The slicing mechanism was broken for some N-dimensional matrices, this update uses a ported variation of the NumPy source code to correctly select slice indices and strides. This update also makes all returns from the slicing views instead os copies, avoiding copies in RAM memory and increasing performance.
feat: New element-wise strided iterator.
An element-wise iterator was implemented in the C backend to centralize and facilitate element-wise operations that must consider strides to return a correct result. This iterator is a derivative work of the iterator used by NumPy.