[bench] pipeline: fix citation counting, oracle validation, and defensive improvements#4
Merged
Merged
Conversation
…sive improvements - Fix broken citation counting in cli/commands.py and utils/viewer.py: citations are dicts, not strings; handle both shapes with fallback logging - Fix _print_entry_line rendering raw dicts instead of constraint IDs - Reject VETO verdicts with empty constraint_citations in oracle validation - Add early OPENROUTER_API_KEY validation before SDK client construction - Move _accumulate_tokens outside else block for consistent token accounting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli/commands.pyandutils/viewer.py— oracle citations are dicts withconstraint_id, not plain strings; both sites now handle both shapes with fallback logging for unknown types_print_entry_line— extractsconstraint_idfrom dicts instead of rendering raw dict repr_accumulate_tokensnow runs unconditionally after the challenger CLEAR/else branchTest plan
🤖 Generated with Claude Code