fix(cli): stop viewer temp file deletion race with browser#5
Merged
Conversation
…ds it Remove the atexit cleanup handler that deleted the HTML temp file immediately on process exit — before the browser had a chance to read it. The file now persists in the OS temp directory for natural cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atexitcleanup handler incmd_viewer()that deleted the HTML temp file immediately on process exit — before the browser had time to load itERR_FILE_NOT_FOUNDwhen opening the viewer on WindowsTest plan
python -m cli viewerand confirm the HTML opens in the browser with ledger data visible