Skip to content

edit 'Considerations for file uploads' and 'Support for x-www-form-ur…#1173

Merged
webron merged 3 commits intoOAI:OpenAPI.nextfrom
krishahn:considerations-for-file-uploads-and-support-for-x-www-form-urlencoded-request-bodies
Jun 13, 2017
Merged

edit 'Considerations for file uploads' and 'Support for x-www-form-ur…#1173
webron merged 3 commits intoOAI:OpenAPI.nextfrom
krishahn:considerations-for-file-uploads-and-support-for-x-www-form-urlencoded-request-bodies

Conversation

@krishahn
Copy link
Copy Markdown
Contributor

…lencoded request bodies'

Comment thread versions/3.0.md Outdated
```

Note that in the above example, the contents in the `requestBody` MUST be stringified per [RFC1866](https://tools.ietf.org/html/rfc1866/) when being passed to the server. In addition, the `address` field complex object will be stringified as well.
In this example, the contents in the `requestBody` MUST be stringified per [RFC1866](https://tools.ietf.org/html/rfc1866/) when being passed to the server. In addition, the `address` field complex object will be stringified.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider dropping "being" as in "when passed to the server".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread versions/3.0.md Outdated
These examples apply to either input payloads of file uploads or response payloads.

A `requestBody` example for submitting a file in a `POST` operation therefore may look like the following:
A `requestBody` for submitting a file in a `POST` operation, however, may look like the following example:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this this should drop the "however".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@webron webron merged commit c517e29 into OAI:OpenAPI.next Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants