Overlay documentation #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lornajane
requested review from
SensibleWood,
handrews,
mkistler and
ralfhandl
Collaborator
SensibleWood
left a comment
SensibleWood
left a comment
There was a problem hiding this comment.
@lornajane looks like a very useful set of examples. Left a couple of suggestions, but nothing massive. Left as comments, feel free to incorporate or ignore.
Contributor
Author
|
Another related issue OAI/Overlay-Specification#34 |
ralfhandl
reviewed
Nov 27, 2024
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
SensibleWood
approved these changes
Nov 27, 2024
Collaborator
SensibleWood
left a comment
SensibleWood
left a comment
There was a problem hiding this comment.
All updates look great. It's a yes from me 👍
ralfhandl
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112 , adding some documentation for users of Overlays.