[13.0][ADD] Contribute Avatax integration #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGPL-3 LICENSE was already included, but it was not yet marked as LGPL-3 in the manifest. Closes #3
Older versions of the integration instead reported to Avalara on a cash basis, but this version does so on an accrual basis.
Although never published on pypi.org Debian Stretch' python3-suds contains suds-jurko 0.7. It's not backwards-compatible with code written for suds-jurko 0.6. Contrary to 0.6, 0.7 respects minOccurs and maxOccurs attributes which caused empty TaxOccurs elements to be inserted. This in turn made Avatax return an error. Additionally, 0.7 no longer maps a WSDL 'decimal' to a Python float. Instead it maps it to a Python Decimal. Fixes #6
If the SO is taxed on delivery address, the invoice should be as well.
Since the tax_id field is readonly in certain cases you cannot rely on the onchanges to handle this. This solves the issue by turning tax_id into a stored computed field. Note that the various onchanges are still necessary to manage the booleans (which should have been a single Selection field).
The standard report uses _get_tax_amount_by_group which relies on account.tax's compute_all. This module doesn't properly overwrite compute_all, so Avatax taxes always are displayed as 0. Solving this by correctly overriding compute_all is not trivial and the risk of introducing other issues is big. Therefore simply don't use _get_tax_amount_by_group on the report.
Member
Author
|
Hello, this is now passing my sanity checks, and I classified it as Beta, to allow distribution to beta users for tests, and later upgrade to stable status. It bundles two modules, |
b-kannan
approved these changes
Jul 15, 2020
b-kannan
left a comment
b-kannan
left a comment
There was a problem hiding this comment.
Functionality testing for sales taxes have been done
a. Sales taxes - invoices and refunds
b. Exemptions on Partners
c. Product taxes
Member
Author
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 681f60e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do: