[16.0] [REF] sale_commission_product_criteria: refactor sql query to be inheritable #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @ilyasProgrammer, |
Tisho99
force-pushed
the
16.0-ref-sale_commission_product_criteria
branch
from
d3dc117 to
73b10dd
Compare
Contributor
Author
|
@manuelregidor Can you review? |
manuelregidor
approved these changes
May 20, 2025
Contributor
Author
|
This PR is a small refactor of this module to make it more inheritable. Could you have a look and give your opinion please? Thank you |
Tisho99
force-pushed
the
16.0-ref-sale_commission_product_criteria
branch
from
73b10dd to
fbf08c8
Compare
Tisho99
changed the title
Contributor
Author
ValentinVinagre
approved these changes
May 22, 2025
Contributor
|
This PR has the |
Contributor
Author
|
@ValentinVinagre There are no higher versions |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at bf3cf14. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the _get_commission_items() function to be able to inherit it from other modules. The new structure is inspired in Odoo report models sql queries.
T-8297