[ADD] contract_sale_generation_payment_mode

[victor-champonnois]

Set the payment mode from the contract on sales orders created by the contract.

[huguesdk]

lgtm! (amended some slight fixes to the commit.)

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[huguesdk]

@OCA/human-resources-maintainers could someone please review or merge this?

[rousseldenis]

@victor-champonnois Thanks for this. Maybe a little test ? Thanks

[victor-champonnois]

@rousseldenis thanks, I've added some tests

[victor-champonnois]

I don't manage to see why the codecov stays red, an idea on how to fix this ?
It states that these lines are not covered, but I don't see a way to cover them more than what I've already did. Can someone help ? :)

+         res = super()._prepare_recurring_sales_values(date_ref)
+         if res:
+             res[0]["payment_mode_id"] = self.payment_mode_id.id
+         return res

[huguesdk]

according to the logs and the coverage report, the test files are loaded, but the tests don’t run. those of contract_sale_generation don’t run either. this is due to a recent change in the tests of contract_sale_generation (in #1201). i fixed it in #1305 (and tagged the tests as post_install here also). i think the coverage will be fine as soon as #1305 is merged.

[victor-champonnois]

many thanks @huguesdk !

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[huguesdk]

@OCA/project-service-maintainers could someone please merge this?

[mamcode]

I think it's fine, but it seems more consistent with the module's design to put this code in the _prepare_sale() method. What do you think?