[18.0] [ADD] product_contract_recurrence_in_price

[qgroulard]

This module extends the functionality of product_contract to add an option to compute
the total amounts on "contract" Sale Order lines, including every invoicing planned.

For instance, a product worth 10€ invoiced every month for one year would have a total
of 120€ (unit_price * #invoices) instead of 10€ (unit_price * quantity).

[OCA-git-bot]

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

[qgroulard]

I have pushed a new version.
The first approach was a bit naive, it was based on the field recurrence_number, which is not the actual number of times the line will be invoiced.
Thus, I add a new field recurring_invoicing_number for this.

[pedrobaeza]

But why do you need an extra multiplier and the quantity is not enough?

[qgroulard]

But why do you need an extra multiplier and the quantity is not enough?

Let's say you sell a subscription over 3 years, invoiced every quarter with a unit price of 100€.

Prior to f50e15d, you would have:

• price_unit = 100.0
• product_uom_qty = 12 (there are 12 quarters in 3 years)

Thus the subtotal of the line would be 1200€ (price_unit * product_uom_qty).
It makes sense, in total the customer will have to pay 1200€ for this subscription.

After f50e15d, you would have:

• price_unit = 100.0
• product_uom_qty = 1
• recurring_interval = 1
• recurring_rule_type = "quarterly"

Without this PR, the subtotal of the line would be 100€ (price_unit * product_uom_qty), which is wrong.
With this PR, we have:

• recurring_invoicing_number = 12 (there are 12 quarters in 3 years) / 1 (recurring_interval)

And the subtotal of the line would be 1200€: 100 (price_unit) * 12 (recurring_invoicing_number) * 1 (product_uom_qty)

[pedrobaeza]

The original intention of the system is that you put on the sale.order.line the "setup" price, and then, when confirmed, the contract is created for the recurring "maintenance" price. What you are telling is that you put in the quotation the full price of the whole "maintenance" price period. That use case sounds very weird, and I think it's over-complicating this module, so it should be handled on extra modules on top.

[qgroulard]

The original intention of the system is that you put on the sale.order.line the "setup" price, and then, when confirmed, the contract is created for the recurring "maintenance" price. What you are telling is that you put in the quotation the full price of the whole "maintenance" price period. That use case sounds very weird, and I think it's over-complicating this module, so it should be handled on extra modules on top.

The use case is the sale of subscriptions.
Recurrences are not maintenance cost, this is a service that the customer pays every month for X years.

I understand that this module can solve different use cases, therefore I have added this as a new option in a new module.

[AnizR]

You aren't setting your field in every cases

Suggested change

	if rec.product_id.is_contract:
	rec.include_recurrence_in_price = (
	rec.product_id.include_recurrence_in_price
	)
	rec.include_recurrence_in_price = rec.product_id.is_contract and (
	rec.product_id.include_recurrence_in_price
	)

[qgroulard]

Done 👍

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[yvaucher]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1289-by-yvaucher-bump-nobump, awaiting test results.

[yvaucher]

I'm merging as it has enough approval, plus the module is separate thus shouldn't affect other module workflow.

[OCA-git-bot]

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1289-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[yvaucher]

Can you rebase?

[qgroulard]

Can you rebase?

Done but the error doesn't seem to be fixed on base branch.

[yvaucher]

The error seems indeed unrelated

In tests module test_subscription_oca in test TestSubscriptionOCA.test_subscription_oca_sub8_workflow
The company bank account linked to this invoice is not trusted, please double-check and trust it before confirming, or remove it

[qgroulard]

The error seems indeed unrelated

In tests module test_subscription_oca in test TestSubscriptionOCA.test_subscription_oca_sub8_workflow The company bank account linked to this invoice is not trusted, please double-check and trust it before confirming, or remove it

Yes, we can see it on other PR as well: #1392, #1390 for instance.

[qgroulard]

Seems to be fixed @yvaucher

[yvaucher]

/ocabot merge nobump

Let's try again

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1289-by-yvaucher-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at c7e0905. Thanks a lot for contributing to OCA. ❤️