Skip to content

[18.0][IMP] contract: Improve contract lines view with section/note support#1381

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
Tecnativa:18.0-imp-contract-form_view
Jan 29, 2026
Merged

[18.0][IMP] contract: Improve contract lines view with section/note support#1381
OCA-git-bot merged 1 commit intoOCA:18.0from
Tecnativa:18.0-imp-contract-form_view

Conversation

@cristina-hidalgo-tecnativa
Copy link
Contributor

This PR improves the contract form view:

  • Apply section_and_note_text widget to name field
  • Apply product_label_section_and_note_field widget to product_id

@Tecnativa TT60295
@christian-ramos-tecnativa

@cristina-hidalgo-tecnativa cristina-hidalgo-tecnativa marked this pull request as draft January 21, 2026 15:35
@cristina-hidalgo-tecnativa cristina-hidalgo-tecnativa marked this pull request as ready for review January 23, 2026 09:08
@cristina-hidalgo-tecnativa cristina-hidalgo-tecnativa force-pushed the 18.0-imp-contract-form_view branch 2 times, most recently from 99cde75 to 4489fb5 Compare January 27, 2026 08:05
Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment
#1381 (comment)

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jan 28, 2026
@pedrobaeza
Copy link
Member

There's something weird trying in runboat: now the list when you uncheck "Recurrence at line level?" is no more editable, while the idea was to have this "easy mode" for doing the edition directly.

@christian-ramos-tecnativa

I think is because when you set the "Recurrence at line level?" the line no longer is editable bottom and the form pop up for you to edit it

@pedrobaeza
Copy link
Member

When I designed this in previous versions, there were 2 one2many fields and different page visibility for handling this, and it was working properly...

@carlos-lopez-tecnativa
Copy link
Contributor

There's something weird trying in runboat: now the list when you uncheck "Recurrence at line level?" is no more editable, while the idea was to have this "easy mode" for doing the edition directly.

It seems that the contract_update_last_date_invoiced module is the one that changes the editable behavior here:

In v17 it works the same way, so this change is unrelated.

Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/ocabot merge minor

Next time, please don't introduce empty lines.

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1381-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 032fd69 into OCA:18.0 Jan 29, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c0f3482. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-imp-contract-form_view branch January 29, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants