Merged
Conversation
sergio-teruel
force-pushed
the
13.0-mig-agreement
branch
from
ce0fd9f to
9e99a62
Compare
Contributor
Author
|
Runbot display fail but is runing... why?? |
Member
|
See the video to know how to get to the problem: Peek.14-02-2021.21-54.mp4 |
sergio-teruel
force-pushed
the
13.0-mig-agreement
branch
from
9e99a62 to
0fc7384
Compare
carlosdauden
approved these changes
Feb 15, 2021
pedrobaeza
requested changes
Feb 15, 2021
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
It seems the migration commit contains black/prettier formatting. Can you please isolate that one so it's not contaminated with it and the review is done more accurately?
| <field name="model_id" ref="model_agreement" /> | ||
| <field | ||
| name="domain_force" | ||
| >['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field> |
Member
There was a problem hiding this comment.
This rule must be transformed and migration scripts should be added. See in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 the line about that.
sergio-teruel
force-pushed
the
13.0-mig-agreement
branch
from
0fc7384 to
9db8c24
Compare
we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)
- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-agreement Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement/
Update agreement and agreement_sale to restore the behavior of v10
pedrobaeza
force-pushed
the
13.0-mig-agreement
branch
from
9db8c24 to
129a028
Compare
pedrobaeza
approved these changes
Feb 15, 2021
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
marcelsavegnago
approved these changes
Feb 15, 2021
Contributor
|
Congratulations, your PR was merged at c3cdae1. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Feb 16, 2021
Merged
olgamarcocb
pushed a commit
to tegin/contract
that referenced
this pull request
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT27165
ping @carlosdauden @CarlosRoca13
Superseeds PR #578 without name changed.