[14.0][FIX] contract: Set fixed date to check test correctly.#966
Merged
OCA-git-bot merged 1 commit intoJun 23, 2023
Merged
Conversation
pedrobaeza
approved these changes
Jun 23, 2023
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Is this for avoiding the problem around midnight? If so, please comment whole problem on the commit message.
We need to set a fixed date for teststest_check_month_name_marker to check against the month of the date we are set (otherwise it would check against the month of today).
victoralmau
force-pushed
the
14.0-fix-contract-test_check_month_name_marker
branch
from
ff92fc9 to
6be12f4
Compare
Member
Author
No, it is a problem specific to |
Member
|
Ok, thanks for the extra commit message. Fast tracking: /ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 76bf8f4. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set fixed date to check test correctly (related to #946).
We need to set a fixed date for
teststest_check_month_name_markerto check against the month of the date we are set (otherwise it would check against the month of today).Please @pedrobaeza and @carlosdauden can you review it?
@Tecnativa