Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

No description provided.

@BhaveshHeliconia
Copy link
Contributor Author

Hi @gurneyalex ,

Could you please review this pull request when you have a moment? I would appreciate any feedback or suggestions for improvement.

Thank you for your time!

@rousseldenis
Copy link

/ocabot migration crm_lead_currency

@rousseldenis
Copy link

@OCA/core-maintainers I'm still questioning about commits done by company account and not individuals.

@rousseldenis
Copy link

rousseldenis commented Dec 3, 2024

@OCA/core-maintainers I'm still questioning about commits done by company account and not individuals.

@HeliconiaSolutions I'm not at ease having contributions done by a global account and not individual one. Of course people can belong to a company (and it can be mentioned on contributors page), but having code that seem written by an undefined group of people is a little bit weird in open-source world.

@BhaveshHeliconia
Copy link
Contributor Author

Dear @rousseldenis,

In relation to OCA/product-attribute#1793, we have carefully clarified and followed the necessary steps to ensure everything aligns with the requirements.

Now regarding OCA/crm#610, we believe the groundwork is now in place, and you can proceed with the PR at your convenience. Please don’t hesitate to reach out if there’s anything further you need from us or if additional clarifications are required.

Together, with mutual support, we can strengthen the community and foster a helpful environment for open-source contributions. Thank you for your time and dedication to this effort.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-crm_lead_currency branch from cf39ff0 to 6840f60 Compare February 7, 2025 10:57
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-crm_lead_currency branch from 6840f60 to a2cefc0 Compare March 31, 2025 10:48
@BhaveshHeliconia BhaveshHeliconia changed the title [MIG] crm_lead_currency: Migration to 18.0 [18.0][MIG] crm_lead_currency: Migration to 18.0 Jul 4, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-crm_lead_currency branch from a2cefc0 to 3abc849 Compare July 4, 2025 08:49
Copy link
Member

@amkarthik amkarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 functional review

@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-610-by-yvaucher-bump-nobump, awaiting test results.

@yvaucher
Copy link
Member

@rousseldenis I agree with you about having contribution as individuals. We can now merge this as the contributor clarified the contributor list with adding himself as an individual.

@BhaveshHeliconia thank you for your contribution.

@OCA-git-bot OCA-git-bot merged commit 1a3de9c into OCA:18.0 Jul 22, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b557afa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.