-
-
Notifications
You must be signed in to change notification settings - Fork 457
[18.0][MIG] crm_lead_currency: Migration to 18.0 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] crm_lead_currency: Migration to 18.0 #610
Conversation
|
Hi @gurneyalex , Could you please review this pull request when you have a moment? I would appreciate any feedback or suggestions for improvement. Thank you for your time! |
|
/ocabot migration crm_lead_currency |
|
@OCA/core-maintainers I'm still questioning about commits done by company account and not individuals. |
@HeliconiaSolutions I'm not at ease having contributions done by a global account and not individual one. Of course people can belong to a company (and it can be mentioned on contributors page), but having code that seem written by an undefined group of people is a little bit weird in open-source world. |
|
Dear @rousseldenis, In relation to OCA/product-attribute#1793, we have carefully clarified and followed the necessary steps to ensure everything aligns with the requirements. Now regarding OCA/crm#610, we believe the groundwork is now in place, and you can proceed with the PR at your convenience. Please don’t hesitate to reach out if there’s anything further you need from us or if additional clarifications are required. Together, with mutual support, we can strengthen the community and foster a helpful environment for open-source contributions. Thank you for your time and dedication to this effort. |
cf39ff0 to
6840f60
Compare
6840f60 to
a2cefc0
Compare
Update field customer_currency_id to be shown only in an opportunity
Currently translated at 100.0% (7 of 7 strings) Translation: crm-14.0/crm-14.0-crm_lead_currency Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_currency/it/
a2cefc0 to
3abc849
Compare
amkarthik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 functional review
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@rousseldenis I agree with you about having contribution as individuals. We can now merge this as the contributor clarified the contributor list with adding himself as an individual. @BhaveshHeliconia thank you for your contribution. |
|
Congratulations, your PR was merged at b557afa. Thanks a lot for contributing to OCA. ❤️ |
No description provided.