[16.0][IMP] crm_claim: Improve search view #622
Conversation
| string="Type" | ||
| name="type" | ||
| string="Category" | ||
| name="category" |
There was a problem hiding this comment.
Don't change this identifier, as it can be used in children modules.
There was a problem hiding this comment.
@pedrobaeza The module has an issue. It has been incorrect from begining and it's quite confusing for users.
The string and name is TYPE but group_by is by categ_id. When they group by type they don't understand the behavior since the field "type" exists on claims and it's added by this module.
It should be consistent. Category should group by category and type should group by type.
We are trying to change this months ago and it seems it's not going to be merged since our PRs are being closed everytime.
Please tell us how we must propose the PR to be merged.
We only want to be consistent behavior on both claim fields
Thank you!
There was a problem hiding this comment.
It has nothing to do with that, Ana. It's a question on stability. If you change the internal name, some modules will stop working. Just change the label, and for the user, the issue will be resolved.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
5 participants
No description provided.