[16.0][REF] ddmrp_exclude_moves_adu_calc_sales: make boolean compute for robustness#541
Merged
OCA-git-bot merged 1 commit intoOCA:16.0from Jun 12, 2025
Merged
Conversation
…bustness The previous approach was error prone as there could be corner cases in which the `exclude_from_adu` field in SO and moves is misaligned. With a compute and inverse methods approach we ensure that there are no misalignments and keep the field in the stock.move as the only source of truth.
Contributor
|
Hi @DavidJForgeFlow, |
Contributor
Author
|
/ocabot merge major |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at ffc387d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach was error prone as there could be corner cases in which the
exclude_from_adufield in SO and moves is misaligned. With a compute and inverse methods approach we ensure that there are no misalignments and keep the field in the stock.move as the only source of truth.Backport of #539