[18.0] edi_core_oca: fix access error on handler model #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @etobella, |
Contributor
Author
I answer myself: they are abstract models, not need for that. |
Contributor
Author
|
Finally added tests 🚀 |
model.model few lines below will trigger an access error w/o this change.
simahawk
force-pushed
the
18-fix-perm
branch
2 times, most recently
from
c9081df to
273ca52
Compare
simahawk
force-pushed
the
18-fix-perm
branch
from
273ca52 to
24b0f49
Compare
Contributor
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 26aeaf0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model.model few lines below will trigger an access error w/o this change.
TODO:
@etobella am I wrong or we miss ACL completely for handler models? 🤔