Skip to content

[16.0][ADD] account_edi_ubl_cii_supplier_invoice_number#1265

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
acsone:16.0-account_edi_ubl_cii_supplier_invoice_number-sbj
Dec 27, 2025
Merged

[16.0][ADD] account_edi_ubl_cii_supplier_invoice_number#1265
OCA-git-bot merged 1 commit intoOCA:16.0from
acsone:16.0-account_edi_ubl_cii_supplier_invoice_number-sbj

Conversation

@sbejaoui
Copy link
Copy Markdown

@sbejaoui sbejaoui commented Dec 22, 2025

This addon extends the UBL invoice import process to automatically populate the suppliers invoice number based on the value found in the XML file.

@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Dec 22, 2025 •
edited
Loading

cc/ @rousseldenis , @jbaudoux, @phschmidt

@sbejaoui sbejaoui mentioned this pull request Dec 22, 2025
Closed
@sbejaoui sbejaoui changed the title [ADD] account_edi_ubl_cii_supplier_invoice_number [16.0][ADD] account_edi_ubl_cii_supplier_invoice_number Dec 22, 2025
phschmidt
phschmidt approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown

@phschmidt phschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

rousseldenis
rousseldenis reviewed Dec 23, 2025
View reviewed changes
Comment thread account_edi_ubl_cii_supplier_invoice_number/__manifest__.py
"website": "https://github.com/OCA/edi",
"depends": [
"account_edi_ubl_cii",
"account_invoice_supplier_ref_unique",
Copy link
Copy Markdown

@rousseldenis rousseldenis Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbejaoui Is this really needed here ?

Copy link
Copy Markdown
Author

@sbejaoui sbejaoui Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supplier_invoice_number is defined in account_invoice_supplier_ref_unique

rousseldenis
rousseldenis reviewed Dec 23, 2025
View reviewed changes
Comment thread account_edi_ubl_cii_supplier_invoice_number/__manifest__.py Outdated
phschmidt
phschmidt approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown

@phschmidt phschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@sbejaoui
[ADD] account_edi_ubl_cii_supplier_invoice_number
c76cfed 
This addon extends the UBL invoice import process to automatically populate the suppliers invoice number based on the value found in the XML file.
@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_supplier_invoice_number-sbj branch from e56ec45 to c76cfed Compare December 23, 2025 08:35
@jbaudoux
Copy link
Copy Markdown
Contributor

jbaudoux commented Dec 27, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 27, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1265-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 27, 2025
@OCA-git-bot
Merge PR #1265 into 16.0
6e26ebc 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 27, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 27, 2025

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1265-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 651ba20 into OCA:16.0 Dec 27, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 27, 2025

Congratulations, your PR was merged at 56ba266. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

+1 more reviewer

@phschmidt phschmidt phschmidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbejaoui @jbaudoux @OCA-git-bot @phschmidt @rousseldenis