Skip to content

[16.0][ADD] account_edi_ubl_cii_purchase_match#1267

Merged
OCA-git-bot merged 3 commits into
OCA:16.0from
acsone:16.0-account_edi_ubl_cii_purchase_match-sbj
Jun 5, 2026
Merged

[16.0][ADD] account_edi_ubl_cii_purchase_match#1267
OCA-git-bot merged 3 commits into
OCA:16.0from
acsone:16.0-account_edi_ubl_cii_purchase_match-sbj

Conversation

@sbejaoui
Copy link
Copy Markdown

@sbejaoui sbejaoui commented Dec 22, 2025

Extend UBL vendor bill import to automatically match and link bill lines to purchase order lines using the OrderReference and product label

@sbejaoui sbejaoui mentioned this pull request Dec 22, 2025
Closed
@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Dec 22, 2025

cc/ @phschmidt , @jbaudoux , @rousseldenis

phschmidt
phschmidt approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown

@phschmidt phschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

jbaudoux
jbaudoux reviewed Dec 27, 2025
View reviewed changes
Comment thread account_edi_ubl_cii_purchase_match/models/account_edi_xml_ubl_20.py Outdated
Comment thread account_edi_ubl_cii_purchase_match/models/account_edi_xml_ubl_20.py Outdated
Comment thread account_edi_ubl_cii_purchase_match/models/account_edi_xml_ubl_20.py Outdated
Comment thread account_edi_ubl_cii_purchase_match/models/account_edi_xml_ubl_20.py Outdated
Comment thread account_edi_ubl_cii_purchase_match/models/account_edi_xml_ubl_20.py Outdated
Comment thread account_edi_ubl_cii_purchase_match/models/account_edi_xml_ubl_20.py Outdated
@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch 2 times, most recently from 7b6468c to ed80be9 Compare December 29, 2025 15:43
@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch 3 times, most recently from 1a32259 to 198d378 Compare February 20, 2026 14:12
@jbaudoux
Copy link
Copy Markdown
Contributor

jbaudoux commented Mar 20, 2026

@sbejaoui Can you attend comments?

@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 198d378 to 9530483 Compare March 23, 2026 16:09
@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Mar 23, 2026

pipeline is red due to another module #1313

@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 9530483 to c4823f7 Compare March 23, 2026 19:17
lmignon
lmignon approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review + functional tests

@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch 3 times, most recently from 5bd2dee to 0b6ba11 Compare April 2, 2026 14:16
@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 0b6ba11 to 4ee5c87 Compare April 15, 2026 08:52
@OCA-git-bot OCA-git-bot added series:16.0 mod:account_edi_ubl_cii_purchase_match Module account_edi_ubl_cii_purchase_match labels Apr 15, 2026
@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 4ee5c87 to d3c5fdb Compare May 27, 2026 08:27
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 27, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 9c42374 to 1392491 Compare May 27, 2026 15:15
@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented May 28, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 28, 2026

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 28, 2026

@sbejaoui The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_account_edi_ubl_cii_purchase_match-16.0.1.0.0.4-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_account_edi_ubl_cii_purchase_match-16.0.1.0.0.4-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Jun 3, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 3, 2026

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 3, 2026

@sbejaoui your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Jun 4, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 4, 2026

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 4, 2026

@sbejaoui your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 1392491 to 36d2831 Compare June 4, 2026 12:41
@sbejaoui sbejaoui mentioned this pull request Jun 5, 2026
Open
sbejaoui added 3 commits June 5, 2026 11:03
@sbejaoui
[ADD] account_edi_ubl_cii_purchase_match
8f57ab3 
Extend UBL vendor bill import to automatically match and link bill lines to purchase order lines using the OrderReference and product label

[IMP] account_edi_ubl_cii_purchase_match: show price_subtotal in purchase line form view

[FIX] account_edi_ubl_cii_purchase_match: allow to change po line

[FIX] account_edi_ubl_cii_purchase_match: don't update supplier info product name

[FIX] account_edi_ubl_cii_purchase_match: match po only if order_ref is set
@sbejaoui
[IMP] account_edi_ubl_cii_purchase_match: support multiple purchase o…
44ba870 
…rders

Extract multiple purchase order references from invoice_origin using
a prefix-based pattern and match them with existing purchase orders
@sbejaoui
[IMP] account_edi_ubl_cii_purchase_match: detect invoiced qty above r…
146ad82 
…eceived qty
@sbejaoui sbejaoui force-pushed the 16.0-account_edi_ubl_cii_purchase_match-sbj branch from 36d2831 to 146ad82 Compare June 5, 2026 09:15
@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Jun 5, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 5, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 5, 2026

@sbejaoui The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_account_edi_ubl_cii_purchase_match-16.0.1.0.0.4-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_account_edi_ubl_cii_purchase_match-16.0.1.0.0.4-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

@sbejaoui
Copy link
Copy Markdown
Author

sbejaoui commented Jun 5, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 5, 2026

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1267-by-sbejaoui-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c283e20 into OCA:16.0 Jun 5, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 5, 2026

Congratulations, your PR was merged at 1eb4709. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

+2 more reviewers

@lmignon lmignon lmignon approved these changes

@phschmidt phschmidt phschmidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:account_edi_ubl_cii_purchase_match Module account_edi_ubl_cii_purchase_match ready to merge series:16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbejaoui @jbaudoux @OCA-git-bot @lmignon @phschmidt