[ADD] account_edi_ubl_cii_retrieve_tax by sbejaoui · Pull Request #1270 · OCA/edi

sbejaoui · 2025-12-25T10:51:41Z

Match taxes on UBL import using UNECE tax codes

jbaudoux

To be safer, I would also parse the tax Scheme

<cac:TaxScheme>
<cbc:ID schemeID="UN/ECE 5153" schemeAgencyID="6">VAT</cbc:ID>
</cac:TaxScheme>

in order to search taxes that are VAT taxes

phschmidt

Functionnal tests

jbaudoux

You need to match a list of taxes based on:

the category : VAT
the id : AE, G, K, ...
the exemption reason code : VATEX-*. This code is not mandatory. It could be a reason text. One of the 2 is normally mandatory when the VAT is 0%

If you match one tax, then use that one.
If you match multiple taxes, typically for reserve charge, intracommunity and export, you need to translate the product tax according to the fiscal position. The fiscal position to use should be identified with the tax id. For that you need to add a selection field on the fiscal position, like you have on the tax with account_edi_ubl_cii_tax_extension.

For example, the product tax is VAT 21% M. The bill as a tax rate=0% ID=AE. The reverse charge (AE) fiscal position translate it to VAT AE 21% M. You need to use that one and not VAT AE 21% S or VAT AE 0% M

hparfr

My comment has been adressed.

OCA-git-bot · 2026-05-26T11:25:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Match taxes on UBL import using UNECE tax codes

jbaudoux · 2026-05-27T08:53:34Z

/ocabot merge nobump

OCA-git-bot · 2026-05-27T08:53:43Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1270-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot · 2026-05-27T09:03:43Z

@jbaudoux The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

jbaudoux · 2026-05-27T10:15:48Z

/ocabot merge nobump

OCA-git-bot · 2026-05-27T10:15:58Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1270-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot · 2026-05-27T10:26:54Z

@jbaudoux The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

sbejaoui · 2026-06-03T15:37:36Z

/ocabot merge nobump

OCA-git-bot · 2026-06-03T15:37:46Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1270-by-sbejaoui-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-03T15:49:13Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1270-by-sbejaoui-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-03T16:00:11Z

@sbejaoui The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

sbejaoui · 2026-06-05T09:22:46Z

/ocabot merge nobump

OCA-git-bot · 2026-06-05T09:22:55Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1270-by-sbejaoui-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-05T09:33:50Z

@sbejaoui The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_account_edi_ubl_cii_retrieve_tax-16.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

sbejaoui · 2026-06-05T11:01:55Z

/ocabot merge nobump

OCA-git-bot · 2026-06-05T11:02:05Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1270-by-sbejaoui-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-05T11:12:52Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1270-by-sbejaoui-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-05T11:23:45Z

Congratulations, your PR was merged at 4f71d81. Thanks a lot for contributing to OCA. ❤️

hparfr reviewed Jan 6, 2026

View reviewed changes

Comment thread account_edi_ubl_cii_retrieve_tax_by_unece_code/models/account_edi_xml_ubl_20.py Outdated

jbaudoux reviewed Jan 9, 2026

View reviewed changes

Comment thread account_edi_ubl_cii_retrieve_tax_by_unece_code/models/account_edi_xml_ubl_20.py Outdated

jbaudoux added this to the 16.0 milestone Jan 9, 2026

phschmidt approved these changes Jan 13, 2026

View reviewed changes

jbaudoux requested changes Mar 20, 2026

View reviewed changes

Comment thread account_edi_ubl_cii_retrieve_tax_by_unece_code/__manifest__.py Outdated

jbaudoux reviewed Mar 20, 2026

View reviewed changes

Comment thread account_edi_ubl_cii_retrieve_tax_by_unece_code/__manifest__.py

sbejaoui force-pushed the 16.0-account_edi_ubl_cii_retrieve_tax_by_unece_code-sbj branch 2 times, most recently from 57d42f3 to 1558ac8 Compare April 1, 2026 15:45

sbejaoui requested review from hparfr and jbaudoux April 1, 2026 15:53

sbejaoui changed the title ~~[ADD] account_edi_ubl_cii_retrieve_tax_by_unece_code~~ [ADD] account_edi_ubl_cii_retrieve_tax Apr 1, 2026

hparfr approved these changes Apr 2, 2026

View reviewed changes

sbejaoui force-pushed the 16.0-account_edi_ubl_cii_retrieve_tax_by_unece_code-sbj branch from 1558ac8 to 4c4a7d7 Compare April 3, 2026 11:04

jbaudoux approved these changes Apr 9, 2026

View reviewed changes

OCA-git-bot added the approved label Apr 9, 2026

sbejaoui force-pushed the 16.0-account_edi_ubl_cii_retrieve_tax_by_unece_code-sbj branch from 4c4a7d7 to 3a4139e Compare April 10, 2026 12:42

sbejaoui mentioned this pull request Apr 10, 2026

[16.0][ADD] account_edi_ubl_cii_retrieve_tax_by_account_prefix #1323

Open

sbejaoui force-pushed the 16.0-account_edi_ubl_cii_retrieve_tax_by_unece_code-sbj branch from 3a4139e to ecee82c Compare May 26, 2026 11:19

OCA-git-bot added series:16.0 mod:account_edi_ubl_cii_retrieve_tax Module account_edi_ubl_cii_retrieve_tax ready to merge labels May 26, 2026

sbejaoui force-pushed the 16.0-account_edi_ubl_cii_retrieve_tax_by_unece_code-sbj branch 2 times, most recently from f2cc72b to d73a73c Compare May 26, 2026 11:26

[ADD] account_edi_ubl_cii_retrieve_tax

340f6fe

Match taxes on UBL import using UNECE tax codes

sbejaoui force-pushed the 16.0-account_edi_ubl_cii_retrieve_tax_by_unece_code-sbj branch from d73a73c to 340f6fe Compare May 27, 2026 08:11

OCA-git-bot added the bot is merging ⏳ label May 27, 2026

OCA-git-bot removed the bot is merging ⏳ label May 27, 2026

OCA-git-bot added the bot is merging ⏳ label May 27, 2026

OCA-git-bot removed the bot is merging ⏳ label May 27, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 3, 2026

OCA-git-bot removed the bot is merging ⏳ label Jun 3, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 5, 2026

OCA-git-bot removed the bot is merging ⏳ label Jun 5, 2026

OCA-git-bot added the bot is merging ⏳ label Jun 5, 2026

OCA-git-bot merged commit b307db7 into OCA:16.0 Jun 5, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 5, 2026

Uh oh!

Conversation

sbejaoui commented Dec 25, 2025

Uh oh!

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phschmidt left a comment

Choose a reason for hiding this comment

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hparfr left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 26, 2026

Uh oh!

jbaudoux commented May 27, 2026

Uh oh!

OCA-git-bot commented May 27, 2026

Uh oh!

OCA-git-bot commented May 27, 2026

Uh oh!

jbaudoux commented May 27, 2026

Uh oh!

OCA-git-bot commented May 27, 2026

Uh oh!

OCA-git-bot commented May 27, 2026

Uh oh!

sbejaoui commented Jun 3, 2026

Uh oh!

OCA-git-bot commented Jun 3, 2026

Uh oh!

OCA-git-bot commented Jun 3, 2026

Uh oh!

OCA-git-bot commented Jun 3, 2026

Uh oh!

sbejaoui commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

sbejaoui commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants