Skip to content

[19.0][MIG] base_business_document_import: Migration to 19.0#1315

Merged
OCA-git-bot merged 99 commits into
OCA:19.0from
camptocamp:19.0-mig-base_business_document_import
Apr 20, 2026
Merged

[19.0][MIG] base_business_document_import: Migration to 19.0#1315
OCA-git-bot merged 99 commits into
OCA:19.0from
camptocamp:19.0-mig-base_business_document_import

Conversation

@yankinmax
Copy link
Copy Markdown

alexis-via and others added 30 commits April 2, 2026 17:15
…voice dict, cleaner organisation)

Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD)
Now support PDF with embedded UBL XML file
Enable unittests on account_invoice_import_ubl
More absolute xpath in account_invoice_import_ubl instead of relative xpath

WARNING: these are big changes, I may have broken a few details
Adapt module account_invoice_import_ubl to use the new base_ubl module
Small fixes
Better generation of address block in UBL (make it coherent with the datamodel of Odoo)
Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party
Add parsing of zip in UBL party (will be used in the future for delivery partner match)
Use country code and state code to match partners
UBL: Add delivery terms and line item UBL XML block generation
UBL: add parsing of delivery block
Add unitests in base_business_document_import
Small code enhancements/simplifications
Code cleanup/minor changes
Rename key 'quantity' to 'qty' in all parsing dicts['lines']
Add common methods compare_lines() and post_create_or_update()
Make sure price_unit is always untaxed in UBL XML files
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
[FIX] LINT

Use try/except when importing external libs
Remove self.ensure_one() that has nothing to do in an api.model method
Rename __openerp__.py to __manifest__.py and set installable to False
Add match for accounts and journals
Improve match for journals and accounts
Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl
… module

Fix spelling mistake and other remarks on README by Tarteo
…o v10.0

base_business_document_import: Add support for the creation of res.bank
Add support for insertion of title in error messages
Add method to create SO in sale.order.import accessible via JSON-RPC
simahawk and others added 7 commits April 2, 2026 17:17
force_company ctx key is deprecated and fallsback to env.company.
The given seller it's a partner: use it properly.
When wrapping the error was still using the seller.name relation which does not exists anymore.
…andling

Add raise_exception argument in several methods
Avoid double entries in chatter
Currently translated at 100.0% (40 of 40 strings)

Translation: edi-18.0/edi-18.0-base_business_document_import
Translate-URL: https://translation.odoo-community.org/projects/edi-18-0/edi-18-0-base_business_document_import/it/
@yankinmax yankinmax force-pushed the 19.0-mig-base_business_document_import branch from 098e9ab to 6460ac2 Compare April 3, 2026 08:16
@yankinmax yankinmax force-pushed the 19.0-mig-base_business_document_import branch from cf26afa to 7e4b4ac Compare April 3, 2026 08:42
@yankinmax yankinmax force-pushed the 19.0-mig-base_business_document_import branch from 7e4b4ac to 59428b0 Compare April 8, 2026 07:10
@yankinmax
Copy link
Copy Markdown
Author

Hello @MohamedOsman7 can you pls take a look?

Copy link
Copy Markdown

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankinmax
Copy link
Copy Markdown
Author

Some commits can be sqashed (guide: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate)

Otherwise: Code Review LGTM

I've squashed administrative and translation commits where possible.

@yankinmax
Copy link
Copy Markdown
Author

Hello @OCA/edi-maintainers can you pls take a look and possibly merge?

Copy link
Copy Markdown
Contributor

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration commit LG

Comment thread base_business_document_import/models/business_document_import.py
@simahawk
Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-1315-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b8efb1e into OCA:19.0 Apr 20, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 2f896c3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.