[19.0][MIG] purchase_order_import_ubl: Migration to 19.0#1336
Open
[19.0][MIG] purchase_order_import_ubl: Migration to 19.0#1336
Conversation
…ort_ubl and purchase_order_ubl
…ally has unittests
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
Rename __openerp__.py to __manifest__.py and set installable to False
Add ubl invoice generation option in accounting config page
…d purchase_order_import_ubl
…iness document is imported in the right company
The ORderResponce document allows a supplier to communicate the ack and the confirmation of an Order documnet. Depending of its content, the PO will be cancelled or confirmed. If the OrderResponse document contains some amended line, the import process will update the picking to reflect the changes
OCA-git-bot
added
series:19.0
mod:purchase_order_import_ubl
Author
|
Hello @vvrossem @ivantodorovich |
yankinmax
force-pushed
the
19.0-mig-purchase_order_import_ubl
branch
from
f38e464 to
f575858
Compare
ivantodorovich
approved these changes
Apr 28, 2026
Comment on lines
+51
to
+61
| Domain.AND( | ||
| [ | ||
| Domain("company_id", "in", [cls.env.company.id, False]), | ||
| Domain.OR( | ||
| [ | ||
| Domain("barcode", "=", product_code), | ||
| Domain("default_code", "=", product_code), | ||
| ] | ||
| ), | ||
| ] | ||
| ), |
Contributor
There was a problem hiding this comment.
(
Domain("company_id", "in", [cls.env.company.id, False])
& (
Domain("barcode", "=", product_code)
| Domain("default_code", "=", product_code)
)
)💡 tip (only suggestion, not change request): one very good thing with the new Domain implementation is that you can use pythonic operators to chain/describe the expression
maybe it's matter of taste, though. Don't change for me, just wanted to share
Author
There was a problem hiding this comment.
This is also nice for chaining and it can be easier to read for a big domains. Agree with your change.
| def test_ubl_order_import_from_embedded_pdf(self): | ||
| """Update an RFQ from a PDF with an embedded UBL quotation.""" | ||
| filename = "quote-PO00004.pdf" | ||
| with file_open(f"purchase_order_import_ubl/tests/files/{filename}", "rb") as f: |
Contributor
There was a problem hiding this comment.
💡 tip: pathlib
quote_file = Path(f"purchase_order_import_ubl/tests/files/{filename}").read_bytes()
no need to change
yankinmax
force-pushed
the
19.0-mig-purchase_order_import_ubl
branch
from
f575858 to
ceb0be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: