[19.0][MIG] partner_event: Migration to 19.0#503
Merged
Conversation
These fields were stored. That usually is good, but if you add partners to an event from the wizard, it means each `res.partner` record gets its `registration_count` field updated.
When you update any record, fields `write_uid` and `write_date` are updated too.
Now imagine you want to add 4000 partners to an event. That would take time. If in the mean time any other user updates the `res.partner` record (along with their `write_UID` and `WRITE_DATE` fields), you would get this error:
```
openerp.sql_db: bad query: UPDATE "res_partner" SET "registration_count"=3,"write_uid"=5,"write_date"=(now() at time zone 'UTC') WHERE id IN (25578)
Traceback (most recent call last):
File "/opt/odoo/common/openerp/v8/openerp/sql_db.py", line 234, in execute
res = self._obj.execute(query, params)
TransactionRollbackError: could not serialize access due to concurrent update
CONTEXT: SQL statement "SELECT 1 FROM ONLY "public"."res_users" x WHERE "id" OPERATOR(pg_catalog.=) $1 FOR KEY SHARE OF x"
```
By removing the `store=True` parameter, you simply avoid those concurrent updates and do not block other users.
But this changes the database structure, so remember to update your database!
If adding 1000 partners, we save now 999 queries. (cherry picked from commit 89853ef)
Currently translated at 100.0% (24 of 24 strings) Translation: event-12.0/event-12.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-partner_event/es/
…oint For speeding up the process. Specially the removal of the savepoints makes that Postgres don't go slow as hell. Check https://www.cybertec-postgresql.com/en/subtransactions-and-performance-in-postgresql/ for some rationale. The problem happens even releasing the previous savepoints. As this module is very old, the reason for doing it this way and skip registrations with error is not fully known, but the view mentions about registration duplication, so let's avoid it and handle later other possible exceptions. TT26694
When we confirm a sale order, the registrations are precreated without the email info, so we were missing the chance to get the info for the partner attendant. Now we compute it on the write as well. TT45149
[UPD] Update partner_event.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/
Currently translated at 100.0% (23 of 23 strings) Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/es/
Currently translated at 100.0% (23 of 23 strings) Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/it/
Steps to reproduce: - Have several partners with the same email. - Generate an event registration for each of the partners. - Launch the contact merge wizard. - Select the destination contact the one with the name that is alphabetically later. - Launch the merge. Current behavior: Model: Event Registration (event.registration), Constraint: event_registration_attendee_partner_id_fkey ERROR: update or delete on table "res_partner" violates foreign key constraint "event_registration_attendee_partner_id_fkey" on table "event_registration" DETAIL: Key (id)=(NNN) is still referenced from table "event_registration" Expected behavior: Succesful merge. The problem arises when ORM launches a flush before unlinking partners. Such recomputation launches a write on existing event registration records, which calls the update of the attendee_partner_id. To prevent it, we just skip such process if performing the merge. TT46798 [UPD] Update partner_event.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/
Currently translated at 100.0% (24 of 24 strings) Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/es/
A user accessing contacts without event access permission will get an event.registration access error. To avoid this, the event user group is added to the event.registration button of the res.partner form. [BOT] post-merge updates [UPD] Update partner_event.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-17.0/event-17.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-17-0/event-17-0-partner_event/
Currently translated at 100.0% (24 of 24 strings) Translation: event-17.0/event-17.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-17-0/event-17-0-partner_event/it/
TT57319 Co-authored-by: Bhavesh Heliconia <oca@heliconia.in>
Contributor
Author
|
@pedrobaeza shall we merge? Same as #482 but with squashed history. The other PR has already 3 reviews but was inactive. |
Member
|
/ocabot migration partner_event I'm missing here #499 |
Contributor
|
The migration issue (#481) has not been updated to reference the current pull request because a previous pull request (#482) is not closed. |
Member
|
/ocabot migration partner_event |
vincent-hatakeyama
approved these changes
May 21, 2026
MohamedOsman7
approved these changes
May 21, 2026
MohamedOsman7
left a comment
MohamedOsman7
left a comment
There was a problem hiding this comment.
Tested! Code & functional review LGTM
|
@pedrobaeza can you merge? |
CRogos
force-pushed
the
19.0-mig-partner_event
branch
from
95b306e to
99de351
Compare
Contributor
Author
|
I've added #499 before the migration via cherry-pick. Tested and working. |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 8e0425b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersede: #482