Skip to content

[18.0][MIG] base geoengine: Migration to 18.0#403

Merged
OCA-git-bot merged 456 commits into
OCA:18.0from
cormaza:18.0-mig-base_geoengine
Jul 17, 2025
Merged

[18.0][MIG] base geoengine: Migration to 18.0#403
OCA-git-bot merged 456 commits into
OCA:18.0from
cormaza:18.0-mig-base_geoengine

Conversation

@cormaza
Copy link
Copy Markdown
Contributor

@cormaza cormaza commented Jun 4, 2025

Standard migration, refactored some methods with new version

Supersed: #386

yvaucher and others added 30 commits May 26, 2025 14:18
geo_contains calls St_Contains SQL search.

Plus fix search to set SRID to avoid mixin srid issue.
And extract Swisstopo to move it in a new module
Otherwise partial value is interpreted as context and it will fails on
Odoo loading
…lways need to zoom out to get useful informations
@cormaza cormaza force-pushed the 18.0-mig-base_geoengine branch 6 times, most recently from d3bc284 to 593403d Compare June 4, 2025 20:44
@cormaza cormaza force-pushed the 18.0-mig-base_geoengine branch from 593403d to 95129b7 Compare June 4, 2025 20:48
Copy link
Copy Markdown

@yterrettaz yterrettaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing this pull request from a functional perspective within the Odoo GeoEngine module. It includes geographic views on a specific object using OSM raster layers. Projections, spatial filters, and geometry types (polygon and point) have been successfully verified during my tests

@Scuottolinx
Copy link
Copy Markdown

Hi, I tested the plugin, and it doesn't behave as it should.
If I create combined vectors using the model_id and model_domain attributes, the result isn't 100% correct:

  • the points on the map are displayed correctly (OK)
  • the detail of individual points, when clicking on a point, is always the same, regardless of the selected point (KO)

Any idea why?

Furthermore, the vector filter in the interface displays this error message when clicked:
Uncaught Promise > Invalid props for component 'DomainSelector': 'domain' is undefined (should be a string)

@Scuottolinx
Copy link
Copy Markdown

Hi, I solved my problem:

The detail of individual points, when clicking on a point, is always the same, regardless of the selected point (KO).

just add the field to

Uncaught Promise > Invalid props for component 'DomainSelector': 'domain' is undefined (should be a string).

This error is due to the fact that the Dialog in Odoo 18 has changed, and therefore in:

  • layers_panel.esm.js, I had to add the "domain" and "onConfirm" attributes.
  • In the DomainSelectorGeoFieldDialog, I obviously defined the same properties.

Maybe it can be useful for a new commit :)

@cormaza
Copy link
Copy Markdown
Contributor Author

cormaza commented Jul 15, 2025

Hi, I solved my problem:

The detail of individual points, when clicking on a point, is always the same, regardless of the selected point (KO).

just add the field to

Uncaught Promise > Invalid props for component 'DomainSelector': 'domain' is undefined (should be a string).

This error is due to the fact that the Dialog in Odoo 18 has changed, and therefore in:

  • layers_panel.esm.js, I had to add the "domain" and "onConfirm" attributes.
  • In the DomainSelectorGeoFieldDialog, I obviously defined the same properties.

Maybe it can be useful for a new commit :)

I will review and back with solution

Copy link
Copy Markdown
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review only

Great work there, and indeed seems more integrated than #386 for the expressions adaptations to odoo core.

@yvaucher
Copy link
Copy Markdown
Member

/ocabot migration base_geoengine

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 17, 2025
@OCA-git-bot
Copy link
Copy Markdown
Contributor

The migration issue (#379) has not been updated to reference the current pull request because a previous pull request (#386) is not closed.
Perhaps you should check that there is no duplicate work.
CC @weinni2000

@yvaucher
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-403-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f729662 into OCA:18.0 Jul 17, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d04616a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.