[17.0][MIG] hr_employee_document_from_applicant: Migration to 17.0#1547
Merged
OCA-git-bot merged 7 commits intoOCA:17.0from Feb 16, 2026
Merged
Conversation
victoralmau
approved these changes
Feb 16, 2026
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
Code and functional review OK
Member
|
/ocabot migration hr_employee_document_from_applicant |
pedrobaeza
reviewed
Feb 16, 2026
| ) | ||
| if applicant_attachments: | ||
| for attachment in applicant_attachments: | ||
| attachment.write( |
Member
There was a problem hiding this comment.
You have to make a copy, not to move them.
Contributor
Author
There was a problem hiding this comment.
This is a change I have added as an improvement, not as part of the migration.
Currently translated at 100.0% (1 of 1 strings) Translation: hr-16.0/hr-16.0-hr_employee_document_from_applicant Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document_from_applicant/it/
pilarvargas-tecnativa
force-pushed
the
17.0-mig-hr_employee_document_from_applicant
branch
from
e319dfd to
b05fbef
Compare
pedrobaeza
reviewed
Feb 16, 2026
Move attachment transfer logic from hr.employee.create to hr.applicant.create_employee_from_applicant to avoid unnecessary execution when creating employees outside recruitment workflow. No behavior change, only performance optimization. TT60569
…hments Change to preserve attachments in applicant record. This maintains recruitment history and prevents data loss if applicant is archived. TT60569
pilarvargas-tecnativa
force-pushed
the
17.0-mig-hr_employee_document_from_applicant
branch
from
b05fbef to
75cadd7
Compare
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 5e13a77. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move attachment transfer logic from hr.employee.create to hr.applicant.create_employee_from_applicant
to avoid unnecessary execution when creating employees outside recruitment workflow.
No behavior change, only performance optimization.
@Tecnativa TT60569
@victoralmau @pedrobaeza please review